Contributing

Contributions are welcome, and they are much appreciated! Every little helps, and we will always give credit.

Types of Contributions

Report Bugs

Report bugs at https://github.com/triton-inference-server/pytriton/issues.

When reporting a bug, please include the following information:

Your operating system name and version.
Any details about your local setup that might be helpful in troubleshooting.
Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" and "help wanted" is open to whoever wants to implement it.

Implement Features

Browse through the GitHub issues for features. Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it.

Write Documentation

The PyTriton could always use more documentation, whether as part of the official PyTriton docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/triton-inference-server/pytriton/issues.

If you are proposing a feature:

Explain in detail how it would work.
Keep the scope as narrow as possible to make it easier to implement.

Sign your Work

We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have the rights to submit it under the same license or a compatible license.

Any contribution which contains commits that are not Signed-Off will not be accepted.

To sign off on a commit, simply use the --signoff (or -s) option when committing your changes:

$ git commit -s -m "Add a cool feature."

This will append the following to your commit message:

Signed-off-by: Your Name <your@email.com>

By doing this, you certify the following:

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

Get Started!

Local Development

Ready to contribute? Here's how to set up the PyTriton for local development.

Fork the PyTriton repo on GitHub.

Clone your fork locally:

$ git clone git@github.com:your_name_here/pytriton.git

Install your local copy into a virtualenv. Assuming you have virtualenvwrapper installed, here's how you set up your fork for local development:
```
$ mkvirtualenv pytriton
$ cd pytriton/
```
If you do not use the virtualenvwrapper package, you can initialize a virtual environment using the pure Python command:
```
$ python -m venv pytriton
$ cd pytriton/
$ source bin/activate
```
Once the virtualenv is activated, install the development dependencies:
```
$ make install-dev
```
Extract Triton Server to your environment so you can debug PyTriton while serving some models on Triton:
```
$ make extract-triton
```
Install pre-commit hooks:
```
$ pre-commit install
```
Create a branch for local development:
```
$ git checkout -b name-of-your-bugfix-or-feature
```
Now you can make your changes locally.

When you're done making changes, check that your changes pass linters and the tests, including testing other Python versions with tox:

$ make lint  # will run, among others, flake8 and pytype linters
$ make test  # will run a test on your current virtualenv

To run a subset of tests:

$ pytest tests.test_subset

Commit your changes and push your branch to GitHub:

$ git add .
$ git commit -s -m "Your detailed description of your changes."
$ git push origin name-of-your-bugfix-or-feature

Submit a pull request through the GitHub website.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

The pull request should include tests.
If the pull request adds functionality, you should update the docs. Put your new functionality into a function with a docstring and add the feature to the list in README.md.

Version management

PyTriton follows the Semantic Versioning scheme for versioning. Official releases can be found on PyPI and GitHub releases. The most up-to-date development version is available on the main branch, which may include hotfixes that have not yet been released through the standard channels. To install the latest development version, refer to the instructions in the Building binaries from source guide.

Documentation

Add/update docstrings as defined in Google Style Guide.

Contributor License Agreement (CLA)

PyTriton requires that all contributors (or their corporate entity) send a signed copy of the Contributor License Agreement to triton-cla@nvidia.com.

NOTE: Contributors with no company affiliation can fill N/A in the Corporation Name and Corporation Address fields.